How to use the Graphite Merge Queue

Add the label 0-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@nnnnoel feel free to just patch the typescript-go submodule rather than having to wait for typescript-go changes

Ref: microsoft/typescript-go#1707

example patch: https://github.com/oxc-project/tsgolint/blob/10689510989fcec60c895ff3d1871822501bc442/patches/0001-Parallel-readDirectory-visitor.patch#L0-L1

@camc314 I applied patch and added test cases for implemented rule

FYI: gen_shims allows reexporting private struct fieds using ExtraFields:

@auvred Thanks, I changed to consistent way to access private struct

I tried some test cases from typescript-eslint and they report errors when they shouldn't? How did you port the test cases across?

--- FAIL: TestStrictBooleanExpressionsRule (10.86s)
    --- FAIL: TestStrictBooleanExpressionsRule/valid-0 (0.05s)
        /Users/cameron/github/oxc-project/tsgolint/internal/rules/strict_boolean_expressions/rule_tester.go:115: Expected valid test case not to contain errors. Code:
            declare const foo: boolean & { __BRAND: 'Foo' };
            if (foo) {
            }
        /Users/cameron/github/oxc-project/tsgolint/internal/rules/strict_boolean_expressions/rule_tester.go:117: error 1 - (53-56) Unexpected mixed type in conditional. The constituent types do not have a best common type.

https://github.com/typescript-eslint/typescript-eslint/blob/0a0a085229523cc6510f3ffb011d7fd93d83045a/packages/eslint-plugin/tests/rules/strict-boolean-expressions.test.ts#L469-L473

Oh, I just requested to Claude code port test file to golang, looks not fine.
I'll try to fix it ASAP.

@camc314 I've migrated all ts tests to go, and passed all cases.

I suppose in the main README, it should be marked as done as well? 🤔